so here when i click a button i am removing the city search params by calling setUrlparams({city:undefined})

As you can see in the network tab, the url that gets requested does not have city on it meaning it might be pushing correctly but the url itself is not updating.

const setUrlParams = (params: Partial<T>) => {
    const urlSearchParams = new URLSearchParams(searchParams.toString())

    Object.entries(params).forEach(([key, value]) => {
      if (!value) {
        urlSearchParams.delete(key)
      } else if (Array.isArray(value)) {
        if (value.length) {
          urlSearchParams.set(key, value.join(","))
        } else {
          urlSearchParams.delete(key)
        }
      } else {
        urlSearchParams.set(key, value)
      }
    })

    const newQuery = urlSearchParams.toString()
    router.replace(`${pathname}${newQuery ? `?${newQuery}` : ""}`, options)
  }