Contribution in increasing tests coverage
Answered
srikanth posted this in #help-forum
srikanthOP
I was looking into next/server code and started learning from merged PRs. I am currently trying to understand this PR by @James : https://github.com/vercel/next.js/pull/58508/
I wanted to add more tests in
Do I create an issue and wait for approvals and labels to be added on it before I start working on them?
I am open to take up any other tests as well.
Thanks for your time in advance.
I wanted to add more tests in
test/unit/incremental-cache/file-system-cache.test.ts, covering other cases as well. I have searched the discord forum and github discussion for contribution in tests. Do I create an issue and wait for approvals and labels to be added on it before I start working on them?
I am open to take up any other tests as well.
Thanks for your time in advance.
Answered by James
This was my first contribution to Next so I created both an issue and a PR, with the issue explaining the bug and the PR explaining the fix. I think if you're just adding tests I'd only raise a PR?
I was surprised at the lack of tests for the file system cache in general so I think any contribution there would be great
I was surprised at the lack of tests for the file system cache in general so I think any contribution there would be great
15 Replies
This was my first contribution to Next so I created both an issue and a PR, with the issue explaining the bug and the PR explaining the fix. I think if you're just adding tests I'd only raise a PR?
I was surprised at the lack of tests for the file system cache in general so I think any contribution there would be great
I was surprised at the lack of tests for the file system cache in general so I think any contribution there would be great
Answer
srikanthOP
that a very helpful input, thanks
No problem
I debated the same thing for ages before deciding to make both 😂
srikanthOP
Hey @James, sorry about the basic question. This being my first contribution, was wondering if I should wait for PR review: https://github.com/vercel/next.js/pull/58933 ?
The checks are passing on azure pipeline.
The checks are passing on azure pipeline.
Nice!
What do you mean?
srikanthOP
I mean, I did not get any review so far.
Will they automatically pick the PR for review or I should reach out to them on some channel?
Will they automatically pick the PR for review or I should reach out to them on some channel?
They'll automatically pick it up
Took around 24 hours for mine
I imagine because yours is tests only it may get a lower review priority than a bug fix
srikanthOP
Understood, thanks for clarification 🙂
14.0.4 seems to have had a lot of canaries
I'm pretty sure when I submitted mine it was was on 14.0.x-canary.13 or something so I thought it might make it through in that version but it wasn't looked at until the next patch
srikanthOP
this is insightful, i am hunting some issues now...😅
will make a note during my next attempt submit a bug fix
will make a note during my next attempt submit a bug fix